deploy templates: increase default npn number for mmnet-model#5178
Merged
Conversation
onetechnical
previously approved these changes
Mar 2, 2023
algobarb
previously approved these changes
Mar 2, 2023
Contributor
|
actually, do we need to update the wallets in the default json to 10? |
algobarb
reviewed
Mar 2, 2023
algobarb
approved these changes
Mar 2, 2023
Contributor
algobarb
left a comment
algobarb
left a comment
There was a problem hiding this comment.
Saw an extra comma but it's non-blocking.
Codecov Report
@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
- Coverage 53.60% 52.11% -1.50%
==========================================
Files 439 439
Lines 54944 54944
==========================================
- Hits 29454 28634 -820
- Misses 23205 23956 +751
- Partials 2285 2354 +69
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default 5 npn appears too small to produce enough load for max TPS tests so set to 10
Test Plan
Manual test